Skip to content

[NFC] Move WinSDK.swift overlay #41785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[NFC] Move WinSDK.swift overlay #41785

wants to merge 2 commits into from

Conversation

stevapple
Copy link
Contributor

@stevapple stevapple commented Mar 11, 2022 •
edited
Loading

Move WinSDK.swift overlay to stdlib/public/Platform, where Glibc.swift overlay lies in.

This further aligns Windows build behavior to Linux, and simplifies directory structure by eliminating stdlib/public/Windows.

Depends on #41691

Resolves SR-NNNN.

@stevapple stevapple changed the title [NFC] Move WindowsSDK.swift overlay [NFC] Move WinSDK.swift overlay Mar 11, 2022
@jckarter
Copy link
Contributor

jckarter commented Apr 6, 2022

How does this look @compnerd?

@compnerd
Copy link
Member

compnerd commented Apr 6, 2022

Hmm, seems like it just moves the location of the file? As long as it doesn't break the installer, I think that should be okay.

@compnerd
Copy link
Member

compnerd commented Apr 6, 2022

@swift-ci please build toolchain Windows platform

1 similar comment
@compnerd
Copy link
Member

compnerd commented Apr 7, 2022

@swift-ci please build toolchain Windows platform

compnerd
compnerd requested changes Apr 12, 2022
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please drop the changes unrelated to the move

@stevapple
Copy link
Contributor Author

@compnerd Which piece of change did you mean by “unrelated”?

@etcwilde etcwilde mentioned this pull request Apr 13, 2022
Closed
@compnerd
Copy link
Member

The changes to the directory creation bits are the "unnecessary" changes. The movement of the file and the target creation should be a no-op.

@stevapple
Copy link
Contributor Author

The changes to the directory creation bits are the "unnecessary" changes. The movement of the file and the target creation should be a no-op.

That commit is in #41691 , where I shared the error encountered with moving WinSDK.swift

@stevapple
Copy link
Contributor Author

This conflicts with the direction shown by #63042, going to close it

@stevapple stevapple closed this Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevapple @jckarter @compnerd